# A self-made personality generator. Try not to laugh

**URL:** <https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882>\
**Category:** I Built This\
**Created:** [August 16, 2019, 12:24am UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882 "2019-08-16T00:24:45Z")\
**Posts on this page:** 6\
**Page:** 1

<div class="post-metadata">

**Author:** ![ConnerOw1115](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/connerow1115/32/326955_2.png) [@ConnerOw1115](https://forum.freecodecamp.org/u/ConnerOw1115)\
**Post date:** [August 16, 2019, 12:24am UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/1 "2019-08-16T00:24:45Z")

</div>

Here is my project:  
[https://codepen.io/Glaurung/pen/yLBOQYG](https://codepen.io/Glaurung/pen/yLBOQYG)  
I hope you like it and have fun!  
Any feedback is appreciated!  
Thanks!

---

<div class="post-metadata">

**Author:** ![fallen-rve](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/fallen-rve/32/158909_2.png) [@fallen-rve](https://forum.freecodecamp.org/u/fallen-rve)\
**Post date:** [August 16, 2019, 12:40am UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/2 "2019-08-16T00:40:56Z")

</div>

This is a beautiful thing. I just spent like 15 minutes playing with this!

I have a couple recommendations:

1. Use the array length to determine the `Math.random` multiplier
2. Instead of having the randomly generated keys in the `.html()` function, pull that out to its own function, like:

```auto
$("#GenButton").on("click",function(){
  $("#s1").html(getPhrase(test1));
  $("#s2").html(getPhrase(test2));
  $("#s3").html(getPhrase(test3));
});

function getPhrase(arr) {
  return arr[Math.floor(Math.random() * arr.length)];
}

```

Otherwise, great work!

---

<div class="post-metadata">

**Author:** ![daedalus6174](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/daedalus6174/32/122103_2.png) [@daedalus6174](https://forum.freecodecamp.org/u/daedalus6174)\
**Post date:** [August 16, 2019, 12:54am UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/3 "2019-08-16T00:54:21Z")

</div>

Nice work! Looks decent on mobile. You might think about setting a max width or something for the desktop version though. And there seems to be a thin vertical line between your first and second yellow text blocks. A fun project, keep it up!

---

<div class="post-metadata">

**Author:** ![ConnerOw1115](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/connerow1115/32/326955_2.png) [@ConnerOw1115](https://forum.freecodecamp.org/u/ConnerOw1115)\
**Post date:** [August 17, 2019, 4:36pm UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/4 "2019-08-17T16:36:24Z")

</div>

Yeah. A max width seems like a good Idea.

---

<div class="post-metadata">

**Author:** ![ConnerOw1115](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/connerow1115/32/326955_2.png) [@ConnerOw1115](https://forum.freecodecamp.org/u/ConnerOw1115)\
**Post date:** [August 17, 2019, 5:20pm UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/5 "2019-08-17T17:20:43Z")

</div>

Thanks! that works MUCH better!

---

<div class="post-metadata">

**Author:** ![ILM](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/ilm/32/363239_2.png) [@ILM](https://forum.freecodecamp.org/u/ILM)\
**Post date:** [February 6, 2021, 1:30pm UTC](https://forum.freecodecamp.org/t/a-self-made-personality-generator-try-not-to-laugh/305882/6 "2021-02-06T13:30:52Z")

</div>