Accessing Object Properties with Variables please tell me where I did wrong

Tell us what’s happening:

Your code so far


// Setup
var collection = {
    "2548": {
      "album": "Slippery When Wet",
      "artist": "Bon Jovi",
      "tracks": [ 
        "Let It Rock", 
        "You Give Love a Bad Name" 
      ]
    },
    "2468": {
      "album": "1999",
      "artist": "Prince",
      "tracks": [ 
        "1999", 
        "Little Red Corvette" 
      ]
    },
    "1245": {
      "artist": "Robert Palmer",
      "tracks": [ ]
    },
    "5439": {
      "album": "ABBA Gold"
    }
};
// Keep a copy of the collection for tests
var collectionCopy = JSON.parse(JSON.stringify(collection));

// Only change code below this line
function updateRecords(id, prop, value) {
  if(value === "") return false;
  collection[id][prop] = value;
  return collection;
}

// Alter values below to test your code
updateRecords(5439, "artist", "ABBA");
updateRecords(5439, "tracks", "Take a Chance on Me");
updateRecords(2548, "artist", "");
updateRecords(1245, "tracks", "Addicted to Love");
updateRecords(2468, "tracks", "Free");
updateRecords(2548, "tracks", "");

console.log(collection["5439"].artist);
console.log(collection["5439"].tracks);
console.log(collection["2548"].artist);
console.log(collection["1245"].tracks);
console.log(collection["2468"].tracks);
console.log(collection["2548"].tracks);

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.90 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/javascript-algorithms-and-data-structures/basic-javascript/record-collection

that will be these 2 lines
why not use else if?

if(value === "") return false;
  collection[id][prop] = value;

Why not use no if statements at all?

return collection[id][prop] || false;

it makes it easier to pass this test if they use something less complicated of course they can do completly without but making it to hard doesn’t sollute it :3

You need to re-read the requirements, you are not handling the cases. Here are two of them in relation to your code.

Your function must always return the entire collection object.

If value is empty (""), delete the given prop property from the album.