After a lot of headache finally made it

Code Feedback
1

Please review it and give feedback
https://shubham10200.github.io/portfolio/

3 Likes
2

Your portfolio looks great! You should probably link to the projects so that we can fully experience them. Their photos look pretty good.

1 Like
3

Thank you so much for appreciation :slight_smile:

4

Wow! nice portfolio website.

5

Hi! The website looks great, seriously. There are a couple of things I would change though.

For the header li elements, you have a :hover like this:

header li:hover {
    border-bottom: 3px solid var(--main-color); 
    transform: translateY(-5px);
    cursor: pointer;
}

This is most likely very nit-picky (just to show how great the website is when these are the only things that can be changed), but if you come from the bottom very slowly, you will reach a point in which the transition is triggered, then the element moves, and then the :hover is gone because the mouse is no longer hovering the element.

I don’t know exactly how to achieve that same behaviour without this side-effect, but if you change the translateY for padding-bottom, you will see something different (similar) without that side-effect. If you are interested we could also try to find how to achieve this behaviour without the side-effect.

And another thing I would change is at the “img-container” inside the “my-work” section. I would have some empty space between the images. The css would look something like this:

section.my-work img {
    transition: 500ms ease-in transform;
    width: 25%;
    margin: 2%;
}

But in general, the website looks really modern and really nice.

1 Like
6

Thank you so much :slight_smile:

1 Like
7

Thanks nikens ! Thank you so much for suggestion and advice . I’ll see suggested changes in website . Thanks a lot again for taking time in viewing my codes :slight_smile:

1 Like