Any correction please....on my tribute page

What is your hint or solution suggestion?

Your comments are very important to me but i have one question to ask that is when i view it my phone there is a white space i don’t want
https://codepen.io/Abdallah-Hidir/pen/JjbRbjq

Challenge: Build a Tribute Page

Link to the challenge:

The link you’ve provided gives a 404 error.
Please provide the correct/updated link to your project.

okay sorry i correct it…
and please any correction on my survey form

Hi @abdallahhidir83 !

It would be better if you created another topic asking for feedback on your survey form.

That way people can focus on giving you feedback just on the tribute page in this topic.

Here are my thoughts on your tribute page.

You need to keep the test suite in the page.
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>

You are currently only passing 1/10 tests. Please open up the test suite and read the full error message to see what needs fixing in order to pass the tests.

For all of the certification projects, you need to make sure all of the tests are passing before you submit the projects.

For codepen you do not need to include the html and head tags.

The center tag is obsolete. If you want to center items please use css instead.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/center

Please avoid inline styles like this style="color: white". Place all of your css in the css section.

Please do not use br tags to create space between elements. Use css instead.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/br

Hope that helps!

Your page looks okay @abdallahhidir83. Some things to revisit (some has been mentioned, some hasn’t);

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 1/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in the HTML editor. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • You’re starting header is h4. You should always start with an h1 header and then have lesser headers as you go down. So your next ones (the three actually) should be h2 since they have the same importance in your page.

I don’t often comment styling but some things you should rethink;

  • on desktop the image is rather large, maybe scale it back a little. looks good on smaller screens
  • remove the footnote links from the text since there are no links to them. (footnote links are the numbers in the square brackets)
  • for a small page like this it’s hard for the user to read small text from one end to the other. you can add some line height to make it a little easer, add some padding on the sides so it’s not so wide and the main part, since it’s a tribute page just hit the highlights and not make it so much a narrative.

I’ve redacted the link to your survey form.
Please create another topic to have it reviewed