Basic JavaScript - Record Collection

Tell us what’s happening:
Hi all, please can I get some insight why this isnt working? I keep getting the error

TypeError: records[id][prop].push is not a function

Your code so far

// Setup
const recordCollection = {
  2548: {
    albumTitle: 'Slippery When Wet',
    artist: 'Bon Jovi',
    tracks: ['Let It Rock', 'You Give Love a Bad Name']
  2468: {
    albumTitle: '1999',
    artist: 'Prince',
    tracks: ['1999', 'Little Red Corvette']
  1245: {
    artist: 'Robert Palmer',
    tracks: []
  5439: {
    albumTitle: 'ABBA Gold'

// Only change code below this line
function updateRecords(records, id, prop, value) {
  if(value === ""){
delete records [id][prop];
  }else if (prop !== "tracks" && value !== ""){
    records[id][prop] = value;
  }else if
    (prop === "tracks" && value !== ""){
      if (records[id].hasOwnProperty("tracks") === false)
  records[id][prop] = [];
  return records;

updateRecords(recordCollection, 5439, 'artist', 'ABBA');

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/ Safari/537.36

Challenge: Basic JavaScript - Record Collection

Link to the challenge:

1 Like

Look more closely you have a mistake with the Syntax (the brakets{})

1 Like

This sort of thing is why using standard formatting is so strongly recommend


ah thanks ill take a closer look!

what is that? (im still not up with all the tech talk!)

I have reformatted your code. It’s very difficult to read if it’s not correctly formatted.
Correct indentation really helps with legibility.
Hopefully you can now see where you have a syntax error (brackets)?

1 Like

Thank you! Where can i read up on correct formatting please? I had no idea that was even a thing!

You should pay attention to the formatting that all of the examples use.

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.