Build a Cargo Manifest Validator [Test #15]

Curriculum Help
1

Tell us what’s happening:

I have gotten all 14 previous tests right, as well test 16, however I’m failing test 15 and I can’t seem to understand why. All the tests I ran came out as they were supposed to. Can someone help me figure this out?

Test 15. If the input manifest object is not valid, your validateManifest function should return an object describing missing and/or invalid properties.

Your code so far

function validateManifest(manifest) {
  let manifestCopy = { ...manifest };
  let errors = {};
  if (manifestCopy.containerId === undefined) {
    errors["containerId"] = "Missing";

  } else if (manifestCopy.containerId == null || !Number.isInteger(manifestCopy.containerId) || manifestCopy.containerId <= 0) {
    errors["containerId"] = "Invalid";
  }

  if (typeof manifestCopy.destination == "number" || typeof manifestCopy.destination == "boolean" || manifestCopy.destination === null || manifestCopy.destination?.trim() == "") {
    errors["destination"] = "Invalid";
  } else if (manifestCopy.destination === undefined) {
    errors["destination"] = "Missing";
  }
  if (manifestCopy.weight === undefined) {
    errors["weight"] = "Missing";
  } else if (manifestCopy.weight == null || manifestCopy.weight <= 0 || typeof manifestCopy.weight != "number" || Number.isNaN(manifestCopy.weight)) {
    errors["weight"] = "Invalid";
  }

  if (manifestCopy.unit === undefined) {
    errors["unit"] = "Missing";
  } else if (manifestCopy.unit == null || manifestCopy.unit.toLowerCase() != "kg" && manifestCopy.unit.toLowerCase() != "lb") {
    errors["unit"] = "Invalid";
  }

  if (manifestCopy.hazmat === undefined) {
    errors["hazmat"] = "Missing";
  } else if (manifestCopy.hazmat == null || typeof manifestCopy.hazmat != "boolean") {
    errors["hazmat"] = "Invalid";
  }

  return errors;
}

Lesson URL (copy - paste from your browser’s address bar)

2

Welcome to the forum @river.karnas

You should have a function named normalizeUnits with a manifest parameter.

The normalizeUnits function is missing from your code.

Happy coding

3

Thanks for the welcoming!

Actually I do have a normalizeUnits function, I pasted only the “validateManifest” function snippet because the bug is about that particular one. The former “normalizeUnits” part of the code had already passed the tests.

4

Please post all of your code. We can’t test fully with just a snippet.

There are two ways you can format your code to make it easier to read and test:

  1. After you copy/paste your code into the editor, select it by dragging your cursor over it then click the (</>) button in the toolbar to automatically wrap your code in backticks. (You can click on the animated demo image below to enlarge it.)

1356×380 401 KB

  1. Manually add three backticks on a new line above your code and on a new line after your code. Note that a backtick is NOT the same as a single quote('). To find the backtick key on your keyboard, see this post.

To see changes to your post as you make them, you can click the (M+) button on the toolbar to bring up the rich text editor:

image
image482×117 7.55 KB

5

Oh, my mistake. I will send the full code below, if it’s best I open a new post please tell me so I can do that. I’m new to the forum, thanks for the patience.

function normalizeUnits(manifest) {
  let manifestCopy = { ...manifest };
  if (manifest.unit == "lb") {
    manifestCopy.unit = "kg";
    manifestCopy.weight = manifest.weight * 0.45;
    return manifestCopy;
  } else {
    return manifestCopy;
  }
}

function validateManifest(manifest) {
  let manifestCopy = { ...manifest };
  let errors = {};
  if (manifestCopy.containerId === undefined) {
    errors["containerId"] = "Missing";

  } else if (manifestCopy.containerId == null || !Number.isInteger(manifestCopy.containerId) || manifestCopy.containerId <= 0) {
    errors["containerId"] = "Invalid";
  }

  if (typeof manifestCopy.destination == "number" || typeof manifestCopy.destination == "boolean" || manifestCopy.destination === null || manifestCopy.destination?.trim() == "") {
    errors["destination"] = "Invalid";
  } else if (manifestCopy.destination === undefined) {
    errors["destination"] = "Missing";
  }
  if (manifestCopy.weight === undefined) {
    errors["weight"] = "Missing";
  } else if (manifestCopy.weight == null || manifestCopy.weight <= 0 || typeof manifestCopy.weight != "number" || Number.isNaN(manifestCopy.weight)) {
    errors["weight"] = "Invalid";
  }

  if (manifestCopy.unit === undefined) {
    errors["unit"] = "Missing";
  } else if (manifestCopy.unit == null || manifestCopy.unit.toLowerCase() != "kg" && manifestCopy.unit.toLowerCase() != "lb") {
    errors["unit"] = "Invalid";
  }

  if (manifestCopy.hazmat === undefined) {
    errors["hazmat"] = "Missing";
  } else if (manifestCopy.hazmat == null || typeof manifestCopy.hazmat != "boolean") {
    errors["hazmat"] = "Invalid";
  }

  return errors;
}
6

Does it make sense to manipulate the value of unit before validating it? Should “KG” be an acceptable value?

And you still need to implement the user stories around the processManifest function.

7

I don’t see it why it shouldn’t be, because even if the user inputs “Kg” or “KG”, it’s logical that they mean “kilograms”, so a simple uppercase shouldn’t invalidate their input.

Yes, I know I still need to implement processManifest, but my question is regarding the validateManifest function only and I’ve only gotten this far. I want to make it pass the #15 test before I proceed to the next function.

8

From the instructions:

  • unit: a string describing the units for the cargo’s weight property (either "kg" for kilograms or "lb" for pounds).
9

I didn’t realize it was meant to be taken literally, I was thinking about input possibilities instead. Fixed that and passed the #15 test. Thank you for your help :slight_smile: