Hi there!
I’ve finished coding and polishing my landing page project. Please let me know what you think, thank you!
Diagon Alley - Product Landing Page
And here are is the link to the challenge itself.
Hi there!
I’ve finished coding and polishing my landing page project. Please let me know what you think, thank you!
Diagon Alley - Product Landing Page
And here are is the link to the challenge itself.
Nice job @sitek94. You page looks good. Just a couple of minor things to revisit;
form
element has the id
attribute repeatedThank you! I’ve fixed that now
Just one question, because it really impress me how you find all these errors / mistakes.
Do you use some additional tool to catch things like this double id for example?
… or is it just experience
Good work!! It looks good and pretty clean!!
Gracias amigo! Veo que eres de Granada, fui ahí el año pasado y me encantó
You know how when you see a typo and it has a greenish glow about it and it smells like bacon? Yeah, me either.
Seriously, sometimes things like that jump out because of many, many code reviews. This one I did catch with the W3C validator.
De nada!! Me alegro que te gustara. Es una ciudad muy bonita, aunque ahora en verano hace muchísimo calor .
Made my day
Okay thank you, so it’s like with everything, practice, practice and a little bit more of practice
@sitek94
on codepen.io you’ll find a down arrow at the top-right in each part of the project HTML, CSS and JavaScript. If you click there, you’ll see Analyze HTML, analyze CSS, analyze JavaScript … , just click there to see any code error. This is your first point to check it all other than some validation issue. You may check it now yourself
Also, codepen.io found duplicate selectors in CSS line 250 and 271 @sitek94, click on Analyze CSS and find the error and fix it yourself.
And,
Good work! Go ahead…
That is so cool! I didn’t know that option, thank you! All fixed now