Build a Set of Football Team Cards - Build a Set of Football Team Cards

Tell us what’s happening:

  1. When the option Position Forward is selected, only forward players should be present within #player-cards.
    Failed:13. When the option Position Midfielder is selected, only midfielder players should be present within #player-cards.
    Failed:14…
    Failed:15…

I don’t know why it won’t work, even though my code works fine and is showing the correct players depending on the select options.

Your code so far

<!-- file: index.html -->
<!DOCTYPE html>
<html lang="en">
  <head>
    <meta charset="UTF-8" />
    <meta http-equiv="X-UA-Compatible" content="IE=edge" />
    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
    <title>
      Build a Set of Football Team Cards
    </title>
    <link rel="stylesheet" href="styles.css" />
  </head>
  <body>
    <h1 class="title">Team stats</h1>
    <main>
      <div class="team-stats">
        <p>Team: <span id="team"></span></p>
        <p>Year: <span id="year"></span></p>
        <p>Head coach: <span id="head-coach"></span></p>
      </div>
      <label class="options-label" for="players">Filter Teammates:</label>
      <select name="players" id="players">
        <option value="all">All Players</option>
        <option value="forward">Position Forward</option>
        <option value="midfielder">Position Midfielder</option>
        <option value="defender">Position Defender</option>
        <option value="goalkeeper">Position Goalkeeper</option>
      </select>
      <div class="cards" id="player-cards">
      </div>
    </main>
    <footer>&copy; freeCodeCamp</footer>
    <script src="./script.js"></script>
  </body>
</html>

/* file: styles.css */
*,
*::before,
*::after {
  box-sizing: border-box;
  margin: 0;
  padding: 0;
}

:root {
  --dark-grey: #0a0a23;
  --light-grey: #f5f6f7;
  --white: #ffffff;
  --black: #000;
}

body {
  background-color: var(--dark-grey);
  text-align: center;
  padding: 10px;
}

.title,
.options-label,
.team-stats,
footer {
  color: var(--white);
}

.title {
  margin: 1.3rem 0;
}

.team-stats {
  display: flex;
  justify-content: space-around;
  flex-wrap: wrap;
  font-size: 1.3rem;
  margin: 1.2rem 0;
}

.options-label {
  font-size: 1.2rem;
}

.cards {
  display: flex;
  flex-wrap: wrap;
  justify-content: center;
  align-items: center;
}

.player-card {
  background-color: var(--light-grey);
  padding: 1.3rem;
  margin: 1.2rem;
  width: 300px;
  border-radius: 15px;
}

@media (max-width: 768px) {
  .team-stats {
    flex-direction: column;
  }
}

/* file: script.js */
const footballTeam = {
  team: "Chelsea FC",
  year: 2004,
  headCoach: "Jose Mourinho",
  players: [
    {
      name: "Petr Cech",
      position: "goalkeeper",
      isCaptain: false
    },
    {
      name: "Carlo Cudicini",
      position: "goalkeeper",
      isCaptain: false
    },
    {
      name: "Lenny Pidgeley",
      position: "goalkeeper",
      isCaptain: false
    },
    {
      name: "Yves Makabu-Makalambay",
      position: "goalkeeper",
      isCaptain: false
    },
    {
      name: "Ricardo Carvalho",
      position: "defender",
      isCaptain: false
    },
    {
      name: "John Terry",
      position: "defender",
      isCaptain: true
    },
    {
      name: "William Gallas",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Jiri Jarosik",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Robert Huth",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Steven Watt",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Wayne Bridge",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Celestine Babayaro",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Paulo Ferreira",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Glen Johnson",
      position: "defender",
      isCaptain: false
    },
    {
      name: "Claude Makélélé",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Aleksey Smertin",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Nuno Morais",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Frank Lampard",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Scott Parker",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Tiago Mendes",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Anthony Grant",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Njitap Geremi",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Joe Cole",
      position: "midfielder",
      isCaptain: false
    },
    {
      name: "Adrian Mutu",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Arjen Robben",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Damien Duff",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Filipe Oliveira",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Didier Drogba",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Mateja Kežman",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Eidur Gudjohnsen",
      position: "forward",
      isCaptain: false
    },
    {
      name: "Mikael Forssell",
      position: "forward",
      isCaptain: false
    }
  ]
}

const selectOptions = document.getElementById("players");
const cardsContainer = document.getElementById("player-cards");

function filterPlayers(filteredPosition) {
  const players = filteredPosition === "all" ? footballTeam.players : footballTeam.players.filter( ({position}) => position === filteredPosition);
  return players
  .map(({ name, position, isCaptain }) => `
    <div class="player-card">
      <h2>${isCaptain ? "(Captain) " : ""}${name}</h2>
      <p>Position: ${position}</p>
    </div>
  `)
  .join("");
}

selectOptions.addEventListener("click", ()=>{
  cardsContainer.innerHTML = filterPlayers(selectOptions.value);
});
//load all of the cards until user selects pos 
cardsContainer.innerHTML = filterPlayers("all");

//loading information
const coach = document.getElementById("head-coach");
const year = document.getElementById("year");
const team = document.getElementById("team");

coach.textContent = footballTeam.headCoach;
year.textContent = footballTeam.year;
team.textContent = footballTeam.team;

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/147.0.0.0 Safari/537.36

Challenge Information:

Build a Set of Football Team Cards - Build a Set of Football Team Cards

Hi @GhadyKeyrouz,

Please use the change event rather than the click event for your select listener.

HTMLElement: change event - Web APIs | MDN

Happy coding!

Ohhh how could I’ve forgotten that, thank you so much!