Build an Apply Discount Function - Build an Apply Discount Function

Curriculum Help
1

Tell us what’s happening:

I’ve spent so much time trying to figure out what might be wrong and I CANNOT understand why I pass the step 3 check but step 4 won’t when it’s the same thing and now I get to know it doesn’t even return the applied discount price when I call the function

Your code so far

def apply_discount(price, discount):
    if price != int or float:
        return "The price should be a number"
    if discount != int or float:
        return "The discount should be a number"
    if price <= 0:
        return "The price should be greater than 0"
    if discount <= 0 or discount > 100:
        return "The discount should be between 0 and 100"
    return price - discount

print(apply_discount(100,20))

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/150.0.0.0 Safari/537.36 OPR/134.0.0.0

Challenge Information:

Build an Apply Discount Function - Build an Apply Discount Function

image_2026-08-28_220037517
image_2026-08-28_2200375171846×903 111 KB

GitHub Link: freeCodeCamp/curriculum/challenges/english/blocks/lab-discount-calculator/695774002591bbc5f8cf3e53.md at main · freeCodeCamp/freeCodeCamp · GitHub

3

Welcome to the forum @FrankLemon,

This is not the way to check if price is type int or float.

Test it by adding this code above it:

    print(price == int)
    print(price == float)

What do you see in the console?

I recommend reviewing this theory lecture:
Understanding Variables and Data Types - How Do the type() and isinstance() Functions Work? | Learn | freeCodeCamp.org

Also, if you are given a discount of 10% on a $50 shirt, what the final price you would pay? Is it 50-10?? Or something else?

Happy coding

4

Yeah no I got it later. I had completely forgotten about the isinstance function and I don’t know what I was thinking about the discount thing I must have been tired lol. Thanks for reaching out!