Can I get feedback on this project please

Hey, freecodecampers I have learned JavaScript here on freecodecamp and I found a project somewhere online and like it. it is a weather app that displays the current weather it was really huge for me really and I edited on it over and over to make it better but as we know we do not know what we don’t know so I could not be aware of my mistakes maybe they are deadly mistakes especially for the JS and API parts maybe there are a lot of things can be done with better practice

so please check my project and give me feedback on the code of it.

here is the link for the repository weather app repoistory

here is the link to the live version weather app live version

Hi @Hamza-Noah !

I think your project looks good.

Here are my thoughts. :slight_smile:

It looks like we have a spelling error here
Screen Shot 2022-05-04 at 7.17.00 PM

For weather apps, it usually common to display both celsius and fahrenheit.
I think that is a feature you should add.

I wasn’t sure what the purpose was for the navbar and footer links so they don’t go anywhere.
Are they just for design purposes or you planning to build out this project to include multiple pages?

When I enter in my location, it looks like the sun icon gets cutoff a little bit.

As for the code, you might consider having a _colors.scss file to store all of your sass variables and then just reuse those variables in the other stylesheets.
I have found that works well, especially for larger projects.

The last thing to consider is what to do in the event that your fetch call doesn’t work properly or is taking to long to fetch the data.

What if the user is waiting a few seconds for their weather data to load, it would be nice to have some sort of loading message, loading icon or placeholder content until the real content comes in.

What if the api is broken?
It might be nice to display a message to the user, like “could not fetch data at this time” instead of showing a blank screen.

Hope that helps!