# Can I get some advice on my solution for Caesars Cipher?

**URL:** <https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504>\
**Category:** General\
**Created:** [October 16, 2017, 9:44pm UTC](https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504 "2017-10-16T21:44:05Z")\
**Posts on this page:** 4\
**Page:** 1

<div class="post-metadata">

**Author:** ![Typical\_Genius](https://avatars.discourse-cdn.com/v4/letter/t/7feea3/32.png) [@Typical\_Genius](https://forum.freecodecamp.org/u/Typical_Genius)\
**Post date:** [October 16, 2017, 9:44pm UTC](https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504/1 "2017-10-16T21:44:05Z")

</div>

```auto
function rot13(str) { // LBH QVQ VG!
  var arr = str.split('');
  function add13(someStr){
    if (someStr.charCodeAt() > 90 || someStr.charCodeAt() < 65) {
      return String.fromCharCode(someStr.charCodeAt() + 0);
    }
    else if ((someStr.charCodeAt() + 13) > 90) {
      return String.fromCharCode(someStr.charCodeAt() + 13 - 90 + 64);    
    } else {
      return String.fromCharCode(someStr.charCodeAt() + 13);
    } 
  }
  var newArr = arr.map(add13);
  var regExp = /-/gi;
  return newArr.join('').replace(regExp, " ");
}

// Change the inputs below to test
rot13("SERR CVMMN!");

```

Any advice on how to make it more readable, concise, clean, etc would be appreciated .

---

<div class="post-metadata">

**Author:** ![Typical\_Genius](https://avatars.discourse-cdn.com/v4/letter/t/7feea3/32.png) [@Typical\_Genius](https://forum.freecodecamp.org/u/Typical_Genius)\
**Post date:** [October 16, 2017, 10:36pm UTC](https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504/4 "2017-10-16T22:36:13Z")

</div>

Whoops! Thanks for blurring that out, I didn’t realize.

---

<div class="post-metadata">

**Author:** ![Typical\_Genius](https://avatars.discourse-cdn.com/v4/letter/t/7feea3/32.png) [@Typical\_Genius](https://forum.freecodecamp.org/u/Typical_Genius)\
**Post date:** [October 16, 2017, 10:36pm UTC](https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504/5 "2017-10-16T22:36:56Z")

</div>

Thanks for the suggestions, I’ll work on trying to implement them.

---

<div class="post-metadata">

**Author:** ![ILM](https://sea3.discourse-cdn.com/freecodecamp/user_avatar/forum.freecodecamp.org/ilm/32/363239_2.png) [@ILM](https://forum.freecodecamp.org/u/ILM)\
**Post date:** [January 17, 2021, 8:37pm UTC](https://forum.freecodecamp.org/t/can-i-get-some-advice-on-my-solution-for-caesars-cipher/153504/6 "2021-01-17T20:37:17Z")

</div>

Closed on January 17, 2021, 8:37pm UTC


