CHARLES: Tribute Page

Code Feedback
1

hello everybody check this out :point_right::point_right: https://codepen.io/chasle/pen/rNNKOpR :point_left::point_left::point_left: your feed back needed please :pray:

2

Hi @chasle, welcome to the forums. Your page looks good. Some things you may want to revisit;

  • codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button and add it into the ‘Stuff for <head>’ box.
    • I mention this mainly because you put the test script in <head> This script should be just before the closing <body> tag. (It doesn’t really matter where you put it for codepen but it shouldn’t be in the head element)
  • codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • You have a couple of typo’s in CSS that you should clean up. They do affect how your page renders.
  • Remember the DRY (Do not Repeat Yourself) principle. In CSS you multiple times have a call to font-family: Arial. There’s an easier way to do it where you only have to type it once.
  • Review the lesson about giving meaningful text to links
  • Make your page responsive. The image does not scale properly on smaller screens.