Code for Profile lookup not working

Tell us what’s happening:
So um… the first three challenges, after over 45min of trying to figure out what is wrong, is still not working. I understand that there is a better way of doing this and I already finished the challenge, but I’m curious of what is wrong with the code below. Thanks!

**Your code so far**

// Setup
var contacts = [
{
    "firstName": "Akira",
    "lastName": "Laine",
    "number": "0543236543",
    "likes": ["Pizza", "Coding", "Brownie Points"]
},
{
    "firstName": "Harry",
    "lastName": "Potter",
    "number": "0994372684",
    "likes": ["Hogwarts", "Magic", "Hagrid"]
},
{
    "firstName": "Sherlock",
    "lastName": "Holmes",
    "number": "0487345643",
    "likes": ["Intriguing Cases", "Violin"]
},
{
    "firstName": "Kristian",
    "lastName": "Vos",
    "number": "unknown",
    "likes": ["JavaScript", "Gaming", "Foxes"]
}
];


function lookUpProfile(name, prop){
// Only change code below this line

for (var i = 0; i < contacts.length; i++){
if(contacts[i].firstName === name && contacts[i].hasOwnProperty(prop))  {
    return contacts[i][prop];
} else if(contacts[i].firstName === name && contacts[i].hasOwnProperty(prop)=== false){
return "No such property";
} else if (contacts[i].firstname !== name){
return "No such contact";
}
}

// Only change code above this line
}

lookUpProfile("Akira", "likes");
**Your browser information:**

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.212 Safari/537.36.

Challenge: Profile Lookup

Link to the challenge:

Formatting helps

function lookUpProfile(name, prop){
// Only change code below this line

  for (var i = 0; i < contacts.length; i++){
    if (contacts[i].firstName === name && contacts[i].hasOwnProperty(prop))  {
      return contacts[i][prop];
    } else if (contacts[i].firstName === name && contacts[i].hasOwnProperty(prop)=== false) {
      return "No such property";
    } else if (contacts[i].firstname !== name) {
      // At this point you're still inside the for loop
      // Have you checked every contact at this point?
      return "No such contact";
    }
  }
}

Still doesn’t work for some reason

What have you changed?

what do you mean by formatting helps? I just looked at your code a bit and then copied it, was I supposed to change something?

Formatting helps see what logic you are implementing.

What have you changed based on the comment I added?

nothing? I looked at your code and it made sense, so I copied it to the challenge and it didn’t work

All I did was format your code. Did you read the comment? There is a logical problem with putting that return statement at that location.

OH MY GOD, I’m so stupid. Thank you SOOO MUCHHH! I just realized that putting the bottom return thing wouldn’t work, you have to put it outside of the for loop!!! THANK YOU

1 Like

We’ve all been there :slight_smile:

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.