Hey there! I finally completed the Responsive Web Design course
I would really appreciate some feedback on my final project:
https://codepen.io/The-Lazy-Coder/full/YzNXPqR
I know it doesn’t pass one of the tests. I don’t want the welcome section to be the height of the viewport all the time, so I ignored that test.
All in all it looks good.
Some observations:
html {
padding: 0px;
margin: 0px;
scroll-behavior: smooth;
}
0
is unitless. You can just write padding: 0
. A small thing and it doesn’t matter much, but I’ve seen things like this flagged in linters.
<div id="pfp">
<div id="image"></div>
</div>
Couldn’t this be done in one div
rather than nesting two? It does this in a few places.
All in all it looks good. Nice job. Have fun with JavaScript.
1 Like
Thank you for your feedback!
system
Closed
4
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.