Critique Tribute to Emmeline Pankhurst

Code Feedback
1

Hi there

Here’s my tribute - celebrating centenary of UK Votes for Women - aimed for a simple responsive design.

(Hope these are the correct links…)

Your feedback appreciated.

Oceanjanie

2

Hi and congrats on completing the project!

The positive things that stand out to me are the slick CSS oval portrait and the use of colored text

I’m no pro but here’s a couple things I noticed you may want to address:

  • Lack of padding/margin at the top of the page, separating the jumbotron from the top of the page.
  • When the site is viewed fullscreen, the jumbotron takes up nearly 100% of the horizontal space. Maybe this is just on my screen (27") but there is a lot of negative grey space, that takes the eye away from the main content.
  • Your a link pointing back to your freeCodeCamp profile is broken. Looks like you are missing the closing bracket on your opening a tag

Also, consider taking some of your CSS out of the HTML section and figuring out how to assign it to your HTML by just placing it in the CSS section.

Good job! and good luck coding!

3

Hi Cewert

Many thanks for these pointers. I am attending a local coding meet up tomorrow so will follow up on your points while I have their support closeby.

Jane

4

That sounds like a great opportunity, Jane. Have fun and good luck!

Charlie

5

Hi I got help on how to fix most of the issues. Thanks again.

Cheers

Jane