Debug an ISBN Validator - Debug an ISBN Validator

Tell us what’s happening:

I’m stuck on the following code test:
When the user enters 1530051126,10, you should see the message Valid ISBN Code. in the console.

I don’t understand why this should be a valid ISBN code. I debugged and stepped through the calculate_check_digit_10 function. Based on the math, the digits_sum = 121, which means the result = 11 (11 - 121 % 11 = 11 - 0 = 11). According to the function, the check digit should be ‘0’. Did I miss something in the requirements? Thank you for your help.

Your code so far

def validate_isbn(isbn, length):
    if len(isbn) != length:
        print(f'ISBN-{length} code should be {length} digits long.')
        return
    main_digits = isbn[0:length]
    given_check_digit = isbn[length - 1]
    main_digits_list = [int(digit) for digit in main_digits]
    # Calculate the check digit from other digits
    if length == 10:
        expected_check_digit = calculate_check_digit_10(main_digits_list)
    else:
        expected_check_digit = calculate_check_digit_13(main_digits_list)
    # Check if the given check digit matches with the calculated check digit
    if given_check_digit == expected_check_digit:
        print('Valid ISBN Code.')
    else:
        print('Invalid ISBN Code.')
def calculate_check_digit_10(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 9 digits by its corresponding weight (10 to 2) and sum up the results
    for index, digit in enumerate(main_digits_list):
        digits_sum += digit * (10 - index)
    # Find the remainder of dividing the sum by 11, then subtract it from 11
    result = 11 - digits_sum % 11
    # The calculation result can range from 1 to 11.
    # If the result is 11, use 0.
    # If the result is 10, use upper case X.
    # Use the value as it is for other numbers.
    if result == 11:
        expected_check_digit = '0'
    elif result == 10:
        expected_check_digit = 'X'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def calculate_check_digit_13(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 12 digits by 1 and 3 alternately (starting with 1), and sum up the results
    for index, digit in enumerate(main_digits_list):
        if index % 2 == 0:
            digits_sum += digit * 1
        else:
            digits_sum += digit * 3
    # Find the remainder of dividing the sum by 10, then subtract it from 10
    result = 10 - digits_sum % 10
    # The calculation result can range from 1 to 10.
    # If the result is 10, use 0.
    # Use the value as it is for other numbers.
    if result == 10:
        expected_check_digit = '0'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def main():
    user_input = input('Enter ISBN and length: ')
    if ',' not in user_input:
        print('Enter comma-separated values.')
    values = user_input.split(',')
    try:
        isbn = values[0]
        length = int(values[1])
    except ValueError:
        print('Length must be a number.')
        return
    if not isbn.isdigit():
        print('Invalid character was found.')
        return
    if length == 10 or length == 13:
        validate_isbn(isbn, length)
    else:
        print('Length should be 10 or 13.')

#main()

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/148.0.0.0 Safari/537.36

Challenge Information:

Debug an ISBN Validator - Debug an ISBN Validator

Github Link: freeCodeCamp/curriculum/challenges/english/blocks/lab-isbn-validator/686b9720ee1d032bd77a480a.md at main · freeCodeCamp/freeCodeCamp · GitHub

Hmm, that’s strange. Could you explain from what parts is ISBN formed?

I am using the test data provided by the instructions in the challenge. The data is entered by the user in response to the 'Enter ISBN and length: ’ input prompt. I input the following…

Enter ISBN and length: 1530051126,10

In this instance, the 10-digit ISBN is 1530051126 and the length is 10

according to the check function the check digit should be 6 which is correct

note you need to pass the first 9 digits to the calculate_check_digit_10 function as a list of integers

did you make any changes to the calculate_check_digit_10 function? I don’t think any change is needed

Thank you ILM! I’m working on this lab as we speak and I noticed my mistake. I was passing the full number of digits (10 for ISBN-10 and 13 for ISBN-13) into the calculate_check_digit_XX functions. My mistake was in the calculation of the main_digits variable. I fixed my code to only pass in the first 9 or 12 digits into the calculate_check_digit_XX functions.