Tell us what’s happening:
I have problems with number 9 (1530051126,10 = Valid) and number 20 (9781947172104,13 = Valid), everything else runs fine. I don’t understand why these 2 specifically don’t work while the other tests of this kind (num = (in)valid) work. Is the problem in the calculate_check_digit functions?
Your code so far
def validate_isbn(isbn, length):
if len(isbn) != length:
print(f'ISBN-{length} code should be {length} digits long.')
return
main_digits = isbn[:length]
given_check_digit = isbn[-1]
if given_check_digit == 'X':
main_digits_list = [int(digit) for digit in main_digits[:-1]]
else:
main_digits_list = [int(digit) for digit in main_digits]
# Calculate the check digit from other digits
if length == 10:
expected_check_digit = calculate_check_digit_10(main_digits_list)
else:
expected_check_digit = calculate_check_digit_13(main_digits_list)
# Check if the given check digit matches with the calculated check digit
if given_check_digit == expected_check_digit:
print('Valid ISBN Code.')
else:
print('Invalid ISBN Code.')
def calculate_check_digit_10(main_digits_list):
# Note: You don't have to fully understand the logic in this function.
digits_sum = 0
# Multiply each of the first 9 digits by its corresponding weight (10 to 2) and sum up the results
for index, digit in enumerate(main_digits_list):
digits_sum += digit * (10 - index)
# Find the remainder of dividing the sum by 11, then subtract it from 11
result = 11 - digits_sum % 11
# The calculation result can range from 1 to 11.
# If the result is 11, use 0.
# If the result is 10, use upper case X.
# Use the value as it is for other numbers.
if result == 11:
expected_check_digit = '0'
elif result == 10:
expected_check_digit = 'X'
else:
expected_check_digit = str(result)
#print(expected_check_digit)
return expected_check_digit
def calculate_check_digit_13(main_digits_list):
# Note: You don't have to fully understand the logic in this function.
digits_sum = 0
# Multiply each of the first 12 digits by 1 and 3 alternately (starting with 1), and sum up the results
for index, digit in enumerate(main_digits_list):
if index % 2 == 0:
digits_sum += digit * 1
else:
digits_sum += digit * 3
# Find the remainder of dividing the sum by 10, then subtract it from 10
result = 10 - digits_sum % 10
# The calculation result can range from 1 to 10.
# If the result is 10, use 0.
# Use the value as it is for other numbers.
if result == 10:
expected_check_digit = '0'
else:
expected_check_digit = str(result)
print(expected_check_digit)
return expected_check_digit
def main():
user_input = input('Enter ISBN and length: ')
if ',' not in user_input:
print('Enter comma-separated values.')
else:
values = user_input.split(',')
#print(values)
isbn = values[0]
if not values[1].isdigit():
print('Length must be a number.')
else:
length = int(values[1])
if not (isbn[:-2].isdigit() and isbn[-1] in '1234567890X') :
print('Invalid character was found.')
else:
if length == 10 or length == 13:
validate_isbn(isbn, length)
else:
print('Length should be 10 or 13.')
#main()
Your browser information:
User Agent is: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:151.0) Gecko/20100101 Firefox/151.0
Challenge Information:
Debug an ISBN Validator - Debug an ISBN Validator