Debug an ISBN Validator - Debug an ISBN Validator

Tell us what’s happening:

Test Step 9
I am getting desired but apparently not correct output. Struggling to debug the issue, primarily because I cannot detect the issue..

Your code so far

def validate_isbn(isbn, length):
    if len(isbn) != length:
        return(f'ISBN-{length} code should be {length} digits long.')
    main_digits = isbn[0:length-1]
    given_check_digit = isbn[length-1]
    main_digits_list = [int(digit) for digit in main_digits[:length-1]]
    # Calculate the check digit from other digits
    if length == 10:
        expected_check_digit = calculate_check_digit_10(main_digits_list)
    else:
        expected_check_digit = calculate_check_digit_13(main_digits_list)
    # Check if the given check digit matches with the calculated check digit
    if given_check_digit == expected_check_digit:
        return('Valid ISBN Code.')
    else:
        return('Invalid ISBN Code.')
def calculate_check_digit_10(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 9 digits by its corresponding weight (10 to 2) and sum up the results
    for index, digit in enumerate(main_digits_list):
        digits_sum += digit * (10 - index)
    # Find the remainder of dividing the sum by 11, then subtract it from 11
    result = 11 - digits_sum % 11
    # The calculation result can range from 1 to 11.
    # If the result is 11, use 0.
    # If the result is 10, use upper case X.
    # Use the value as it is for other numbers.
    if result == 11:
        expected_check_digit = '0'
    elif result == 10:
        expected_check_digit = 'X'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def calculate_check_digit_13(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 12 digits by 1 and 3 alternately (starting with 1), and sum up the results
    for index, digit in enumerate(main_digits_list):
        if index % 2 == 0:
            digits_sum += digit * 1
        else:
            digits_sum += digit * 3
    # Find the remainder of dividing the sum by 10, then subtract it from 10
    result = 10 - digits_sum % 10
    # The calculation result can range from 1 to 10.
    # If the result is 10, use 0.
    # Use the value as it is for other numbers.
    if result == 10:
        expected_check_digit = '0'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def main():
    user_input = input('Enter ISBN and length: ')
    if ',' not in user_input:
        print("Enter comma-separated values.")
    values = user_input.split(',')
    isbn = values[0].strip()  # Remove leading/trailing whitespace
    try:
        length = int(values[1].strip())  # Remove leading/trailing whitespace and convert to int
    except ValueError:
        print('Length must be a number.')
        return
    if length != int:
        print('Invalid character was found.')
        return
    if length == 10 or length == 13:
        validate_isbn(isbn, length)
    else:
        print('Length should be 10 or 13.')

#main()
print(validate_isbn('1530051126', 10))

Your browser information:

User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/27.0 Safari/605.1.15

Challenge Information:

Debug an ISBN Validator - Debug an ISBN Validator

GitHub Link: freeCodeCamp/curriculum/challenges/english/blocks/lab-isbn-validator/686b9720ee1d032bd77a480a.md at main · freeCodeCamp/freeCodeCamp · GitHub

Welcome to the forum @kmajor

You need to use a number, not a string for the first argument.

Try this print call:

print(validate_isbn(1530051126,10))

Happy coding

Yes!! Excellent, thank you! I was able to fully satisfy all test objectives. Learned a lot in this one.