Debug an ISBN Validator

Tell us what’s happening:

I am stuck at this: 11. When the user enters 1530051125,10, you should see the message Invalid ISBN Code..

Your code so far

def validate_isbn(isbn, length):
    if len(isbn, length) != length:
        print(f'ISBN-{length} code should be {length} digits long.')
        return
    main_digits = isbn[0:length-2]
    given_check_digit = isbn[length-1]
    main_digits_list = [int(digit) for digit in main_digits]
    # Calculate the check digit from other digits
    if length == 10:
        expected_check_digit = calculate_check_digit_10(main_digits_list)
    else:
        expected_check_digit = calculate_check_digit_13(main_digits_list)
    # Check if the given check digit matches with the calculated check digit
    if given_check_digit == expected_check_digit:
        print('Valid ISBN Code.')
    else:
        print('Invalid ISBN Code.')
def calculate_check_digit_10(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 9 digits by its corresponding weight (10 to 2) and sum up the results
    for index, digit in enumerate(main_digits_list):
        digits_sum += digit * (10 - index)
    # Find the remainder of dividing the sum by 11, then subtract it from 11
    result = 11 - digits_sum % 11
    # The calculation result can range from 1 to 11.
    # If the result is 11, use 0.
    # If the result is 10, use upper case X.
    # Use the value as it is for other numbers.
    if result == 11:
        expected_check_digit = '0'
    elif result == 10:
        expected_check_digit = 'X'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def calculate_check_digit_13(main_digits_list):
    # Note: You don't have to fully understand the logic in this function.
    digits_sum = 0
    # Multiply each of the first 12 digits by 1 and 3 alternately (starting with 1), and sum up the results
    for index, digit in enumerate(main_digits_list):
        if index % 2 == 0:
            digits_sum += digit * 1
        else:
            digits_sum += digit * 3
    # Find the remainder of dividing the sum by 10, then subtract it from 10
    result = 10 - digits_sum % 10
    # The calculation result can range from 1 to 10.
    # If the result is 10, use 0.
    # Use the value as it is for other numbers.
    if result == 10:
        expected_check_digit = '0'
    else:
        expected_check_digit = str(result)
    return expected_check_digit
def main():

    user_input = input('Enter ISBN and length: ')
    if ',' not in user_input:
        print("Enter comma-separated values.")
    values = user_input.split(',')

    digit_count = len(values[0])
    try:
        isbn = int(values[0])
    except:
        print("Invalid character was found.")

    try:
        length = int(values[1])
    except:
        print("Length must be a number.")
    
    if length == 13 and digit_count != 13:
        print("ISBN-13 code should be 13 digits long.")
    
    if length == 10 and digit_count != 10:
        print("ISBN-10 code should be 10 digits long.")

    if length == 10 or length == 13:
        print("Valid ISBN Code.")
        validate_isbn(isbn, length)
    else:
        print('Length should be 10 or 13.')

#main()

Your browser information:

User Agent is: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/143.0.0.0 Safari/537.36

Challenge Information:

Debug an ISBN Validator - Debug an ISBN Validator

call the main() function and test it out

Enter ISBN and length: 
1530051125,10
Valid ISBN Code.
Traceback (most recent call last):
  File "main.py", line 85, in <module>
  File "main.py", line 81, in main
  File "main.py", line 2, in validate_isbn
TypeError: len() takes exactly one argument (2 given)

there are still some bugs with the code

Hello. I’m stuck at the same point, I would like to simply ask why 1530051125,10 should not be Valid? I wish to undestand the criteria so I can implement it to the code.. Thanks

please create your own topic to ask your questions

If you have a question about a specific challenge as it relates to your written code for that challenge and need some help, click the Get Help > Ask for Help button located on the challenge.

The Ask for Help button will create a new topic with all code you have written and include a link to the challenge also. You will still be able to ask any questions in the post before submitting it to the forum.

Thank you.

1 Like