Dont know one test is not passing can anybody tell me why

Tell us what’s happening:

Your code so far


// Setup
var collection = {
2548: {
  albumTitle: 'Slippery When Wet',
  artist: 'Bon Jovi',
  tracks: ['Let It Rock', 'You Give Love a Bad Name']
},
2468: {
  albumTitle: '1999',
  artist: 'Prince',
  tracks: ['1999', 'Little Red Corvette']
},
1245: {
  artist: 'Robert Palmer',
  tracks: []
},
5439: {
  albumTitle: 'ABBA Gold'
}
};

// Only change code below this line
function updateRecords(object, id, prop, value) {
if (value === '') delete object[id][prop];
else if (prop !== 'tracks'){
  object[id][prop] = value
}
else if (prop === 'tracks') {
  object[id][prop] = [];
  object[id][prop].push(value)
}
else if (value !== '' && prop === 'tracks') {
  object[id][prop].push(value)
}

return object;

}

updateRecords(collection, 5439, 'artist', 'ABBA');

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.102 Safari/537.36.

Challenge: Record Collection

Link to the challenge:

If prop is tracks and value isn’t an empty string, add value to the end of the album’s existing tracks array.

Your code:

else if (prop === 'tracks') {
  object[id][prop] = [];
  object[id][prop].push(value)
}

You’re always setting tracks to an empty array, and then adding the value, therefore deleting all the previous tracks.

1 Like

ok got it thanks it helped very much cuz i was stuck from half an hour