Extract Local State into Redux what's wrong?

JavaScript
1

Tell us what’s happening:
I feel like I’ve done everything the instruction asks. Can someone help please?

Your code so far


// Redux:
const ADD = 'ADD';

const addMessage = (message) => {
  return {
    type: ADD,
    message: message
  }
};

const messageReducer = (state = [], action) => {
  switch (action.type) {
    case ADD:
      return [
        ...state,
        action.message
      ];
    default:
      return state;
  }
};

const store = Redux.createStore(messageReducer);

// React:
const Provider = ReactRedux.Provider;
const connect = ReactRedux.connect;

// Change code below this line
class Presentational extends React.Component {
  constructor(props) {
    super(props);
    this.state = {
      input: ''
    }
    this.handleChange = this.handleChange.bind(this);
    this.submitMessage = this.submitMessage.bind(this);
  }
  handleChange(event) {
    this.setState({
      input: event.target.value
    });
  }
  submitMessage() {
    dispatch(this.props.submitNewMessage(this.state.input));
    this.setState({
      input: ''
    });
  }
  render() {
    return (
      <div>
        <h2>Type in a new Message:</h2>
        <input
          value={this.state.input}
          onChange={this.handleChange}/><br/>
        <button onClick={this.submitMessage}>Submit</button>
        <ul>
          {this.props.messages.map( (message, idx) => {
              return (
                 <li key={idx}>{message}</li>
              )
            })
          }
        </ul>
      </div>
    );
  }
};
// Change code above this line

const mapStateToProps = (state) => {
  return {messages: state}
};

const mapDispatchToProps = (dispatch) => {
  return {
    submitNewMessage: (message) => {
      dispatch(addMessage(message))
    }
  }
};

const Container = connect(mapStateToProps, mapDispatchToProps)(Presentational);

class AppWrapper extends React.Component {
  render() {
    return (
      <Provider store={store}>
        <Container/>
      </Provider>
    );
  }
};

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36.

Link to the challenge:
https://learn.freecodecamp.org/front-end-libraries/react-and-redux/extract-local-state-into-redux

1 Like
2

Hi @shimphillip

You’ve called dispatch unnecessarily in submitMessage(). mapDispatchToProps handles the dispatching for you so you only need to call the function.

In actual fact, in that context, dispatch doesn’t exist so I’m surprised there’s no errors being logged to the console.

// Yours
dispatch(this.props.submitNewMessage(this.state.input));

// Should be
this.props.submitNewMessage(this.state.input);
1 Like
3

Worked like a magic. Thanks!

4

I made exactly the same mistake. Must be how the challenge is worded!

Next, modify the submitMessage() method so that it dispatches submitNewMessage()

As you wrote a function in a previous test using dispatch the wording confuses you.

1 Like