FCC Feedback For Tribute Page Requested Please

Hello FCC Community :wave:t4:,

I’d appreciate feedback on my Tribute Page.

I struggle much more than I expected to develop this and feel a bit like Homer.

I’d particularly appreciate feedback on:

  • What best practice am I missing?
  • How could I make the code more efficient?
  • Is there any redundant / optimisations I could make?

I’m very grateful to the FCC community for their selfless assistance.

Hi @danieljohnsonxyz !

Welcome to the forum!

This comes up a lot in the forum where people will replicate the sample project but the goal of these projects is to build something different from the sample.

I understand that it is difficult to build your first project but you will learn a lot more in the process if you don’t duplicate the sample. :grinning:
Something to keep in mind for the future.


Here are my thoughts on your project

I would review the lesson on giving links meaningful names.

wikipedia page is not that accessible.

In codepen, you don’t need to include the doctype, html and head tags.
That is already built into codepen.

Codepen also has a formatting tool.
Properly formatted code will make your code more readable.
Screen Shot 2021-06-09 at 11.49.10 AM

Hope that helps!

Hi @jwilkins.oboe first of all, thank you for your helpful and useful feedback - it’s appreciated.

I have a few questions:

  1. The CSS and HTML were apparently OK with respect to the analysis function. Do you see anything I could have done to improve the code in terms of quality / best practice.
  2. Do you think I should redo it with my own ‘style’?

Thanks!

You still haven’t fixed the accessibility issue with the wikipedia page link.
Accessibility is important so I would review that lesson I mentioned earlier.

You also still haven’t formatted your code.
It is important to properly format your code so it makes it easier for other developers to read it.

Stuff like this is not good practice.

<ul>
<li><strong>1914</strong> - Born in Cresco, Iowa</li>
<li><strong>1914</strong> - Born in Cresco, Iowa</li>
<li><strong>1914</strong> - Born in Cresco, Iowa</li>
</ul> 

or stuff like this

#img-div {
      background-color: white;
      padding-bottom: 10px;
    }
  img {
    padding-top: 10px;
    height: auto;
    max-width: 600px;
    margin: auto;
    display: block;
  }

I would.
You will learn a lot more by creating your own page than recreating the sample.