FCC not passing the tests

JavaScript
1

The tests work fine but I am not able to pass it.
The problem is similar with the Exercise tracker and file metadata.

Your code so far

const port = 3000;

const express = require('express');
require('dotenv').config();
const dns = require('dns');
const bodyParser = require('body-parser');
const mongodb = require('mongodb');
const mongoose = require('mongoose');


const app = express();

app.use(bodyParser.urlencoded({ extended: false }));


app.use(express.static(`${__dirname}/public`));


mongoose.connect(process.env.MONGO_URI, {
  useNewUrlParser: true
});


const { Schema } = mongoose;

const urlSchema = new Schema({
  original_url: {
    type: String,
    required: true
  },
  short_url: {
    type: Number,
    required: true,
    default: 0
  }
});


const Url = mongoose.model('Url', urlSchema);


app.get('/', (req, res) => {
  res.sendFile(`${__dirname}/views/index.html`);
});


app.post('/api/shorturl', (req, res) => {
 
  const urlRequest = req.body.url;

  
  const hostname = urlRequest
    .replace(/http[s]?\:\/\//, '')
    .replace(/\/(.+)?/, '');

  
  dns.lookup(hostname, (lookupErr, addresses) => {
    if (lookupErr) {
      console.log('lookup() error');
    }
  
    if (!addresses) {
      res.json({
        error: 'invalid URL'
      });
    } else {
     
      Url.findOne({
        original_url: urlRequest
      }, (findOneErr, urlFound) => {
        if (findOneErr) {
          console.log('findOne() error');
        }
        
        if (!urlFound) {
          
          Url.estimatedDocumentCount((countErr, count) => {
            if (countErr) {
              res.send('estimatedDocumentCount() error');
            }
           
            const url = new Url({
              original_url: urlRequest,
              short_url: count + 1
            });

            
            url.save((saveErr, urlSaved) => {
              if (saveErr) {
                res.send('save() error');
              }
             
              res.json({
                original_url: urlSaved.original_url,
                short_url: urlSaved.short_url
              });
          
            });
          
          });
       
        } else {
         
          res.json({
            original_url: urlFound.original_url,
            short_url: urlFound.short_url
          });
        }
      }); 
    } 
  }); 
}); 


app.get('/api/shorturl/:shorturl', (req, res) => {
  
  const { shorturl } = req.params;

  Url.findOne({
    short_url: shorturl
  }, (err, urlFound) => {
    if (err) {
      console.log('findOne() error');
    }
    
    if (!urlFound) {
      res.json({
        error: 'no matching URL'
      });
    } else {
     
      res.redirect(urlFound.original_url);
    }
  }); 
}); 


app.listen(port);
console.log(`listening on port ${port}`);

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.85 Safari/537.36.

Challenge: URL Shortener Microservice

Link to the challenge:

2

I’ve edited your post for readability. When you enter a code block into a forum post, please precede it with a separate line of three backticks and follow it with a separate line of three backticks to make it easier to read.

You can also use the “preformatted text” tool in the editor (</>) to add backticks around text.

Pre-formatted-text
Pre-formatted-text1356×380 401 KB

See this post to find the backtick on your keyboard.
Note: Backticks (`) are not single quotes (’).

3

Welcome there,

Would you mind sharing a link to your app?

4

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.