Feedback for Coffee Tribute Page

Hi everybody!

Just completed my first project with all tests passing. I’d appreciate any and all feedback, but especially on the CSS - I feel the code could be more concise and I’m not sure my approach to making the elements responsive (i.e. media queries, variable font-sizing) is the most logical…

Here’s the link:

Thanks in advance and happy coding!

1 Like

Welcome to the forums @jonathanhshine. Your page looks good. Some things to revisit;

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags or other elements that are outside of body). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • Review the lesson about giving meaningful text to links.
  • You have multiple declaration blocks for the same media query. It’s easier to maintain (and easier to read) if they were only one at the bottom rather than scattered throughout.
1 Like

Thank you for the feedback @Roma!

I made the suggested changes - got rid of the extraneous HTML tags, the links are more informative, and put the CSS declarations under one media query. You’re right, it looks a lot cleaner! Thanks again :slight_smile:

1 Like