Feedback for Quote Machine Project

Hi everyone, it is my first post in the FreeCodecamp forums! Even though is my first post I’ve read a lot of things you guys posted and learned a lot in the past month. Thank you all.

This is my Quote Machine project. https://yusufipk.github.io/quote-machine/

Code: https://github.com/yusufipk/quote-machine

One thing I didn’t get, in order to past 2 tests I need to click new quote button or 2 tests pends and fails. Any feedback would be great! Thanks again.

1 Like

This is clearly freecodecamp tests failing due to timeout. I guess using async with “componentDidMount()” is causing the error. It’s just a guess though. Give it a try.

2 Likes

I’ve just viewed your page on my mobile and it isn’t fully resposive. I think you meant to have your quote in middle of page but it is showing at bottom and text is going over the button. Your container div should be set to height: 100vh and then the quote box can be set to the appropriate size inside it. You then position the div using flexbox.

2 Likes

Thank you for the tips! I’ve made the box more responsive now.

2 Likes

Hey, for the Tweet link you’ve got an <a> embedded in an <a>. That’s not valid HTML and you’ll definitely want to fix that.

2 Likes

Much better! Good job.

2 Likes