Feedback for Tribute and Product Landing Page(s)

Code Feedback
1

Hello,

I was wondering if I can get some feedback for my projects. I’ve already submitted my tribute page, but I’ve been thinking of going back to it to improve on it.

Tribute Page - Isao Takahata
Product Landing Page - Glass Pens

2

Your pages looks good @ginstation.24. You can edit any of your pens if you want. If you edit the same pen and all the tests pass you don’t have to resubmit.

Some things to revisit for each;

tribute

  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
  • It’s not a good idea to drastically change the way a link looks
    • It’s not obvious that the sources are links or that the quote is a link
    • what about those on smaller screens that do not have hover capability?
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
  • Read the following concerning using the h1 element as a top level heading only

product page

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.