Feedback for tribute page scorsese

Code Feedback
1

Can you give me some feedback on the tribute page project?

Your browser information:

User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:89.0) Gecko/20100101 Firefox/89.0

Challenge: Build a Tribute Page

Link to the challenge:

2

Looks good, I like the fonts and colors.

  1. You should use two paragraphs for the bio section instead of a br element. Give them some margin as well to separate the paragraphs.

  2. I would give the list items some margin to space them out.

  3. You have an odd group selector h4, h4, doesn’t really make sense to group an h4 with an h4. Probably just a mistake.

  4. The last h3 selector is outside any media query, as such it will just always overwrite the other h3 selector you have (making one of them a duplicate selector).

  5. The image grid is beyond the scope of the challenge so that’s just icing on the cake, but if it was for the portfolio challenge I would say it might still need a bit of love. The main issue is the length of the “The Wolf of Wall Street” title which is messing up the layout a bit. There are likely a few different ways to try and deal with it, but like I said it’s kind of out of scope.

Good job, keep it up.

1 Like
3

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.