Feedback for Tribute Page - Thanks!

Hello to all. I am currently a student, and use FreeCodeCamp to supplement my learning from my studies. I have completed the Tribute Page to my knowledge and best ability. Any feedback would be greatly appreciated, as I am always looking to improve my skills. Thanks guys and gals and Happy Coding!

https://codepen.io/wheel-c-code/pen/poWaGex

1 Like
  1. It looks a lot better than mine
  2. Your chosen person/topic is a lot better than mine (my girlfriend’s cat, Meatball)
  3. The layout is interesting and grabbing, especially the tiles at the bottom. They look nice/clean
  4. The poll at the very bottom seems a bit small in comparison to the rest, so that could possibly be improved with some resizing/centering/what-have-you
1 Like

Maybe darken the background a bit so you don’t get the dark circles effect between the boxes,

Hi @wheel.c.code !

Welcome to the forum!

I think your page looks good.

Just a couple of things :grinning:

You have a few errors in your html.
When you finish a project it is always best to run your code through a validator to check of errors.
Codepen does have a validator but you can also use the html validator

Some of the issues include a missing alt atrribute here

    <img id="logo" src="https://freesvg.org/img/George-Washington-Carver.png">

Remember that alt attributes are important for accesibility reasons.

Also, you have a few duplicate ids.
For example, id="card"

Remember that ids have to be unique.
Class names can be reused over and over again.

It looks like you have a small error in your css.
I would use the codepen css analyzer to find and fix that error
Screen Shot 2022-01-04 at 3.45.09 PM

Hope that helps and keep up the good work! :grinning:

Welcome to the forums @wheel.c.code. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    The test script, with all tests passing, should be included when you submit your projects.
    Your page passes 2/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
    Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
      Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
      (The one for HTML misses things which is why I recommend W3C)
  • Do not use the <br> element to force line breaks or spacing. That’s what CSS is for.
    Reference MDN Docs

Good evening. Thank you for taking the time to provide feedback. I will take your advice and implement what you suggested.

Happy Coding!

Thank you for the advice!

Good evening,

First and foremost, I must say that is encouraging to see someone that looks like me in the industry. That alone is enough to keep me motivated! Thank you for taking the time to provide feedback and I will be sure to implement your advice.

Thank you for taking the time to provide valuable feedback. Your suggestions are very helpful and I will be sure to implement your advice.