Feedback on 1st Tribute Page Project

Feedback on 1st Tribute Page Project
0

#1

Hi all,

I’ve finally finished my first project! If anyone has a moment to spare, I’d really appreciate any feedback you have.

On the assignment post the instructions say that they used barely any CSS and only Bootstrap. I used Bootstrap, but also some CSS. Not sure if that’s a bad thing?

Here is my Codepen:

http://codepen.io/nabramow/pen/ZOxdKN

:slight_smile:

Best,

Nicole


#2

Hi @nabramow ,

CSSlinter:

  • Unknown property ‘text-color’.
h1 {
...
  text-color: black;
...
}

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/CSS/color

The color property sets the foreground color of an element’s text content, and its decorations. It doesn’t affect any other characteristic of the element; it should really be called text-color and would have been named so, save for historical reasons and its appearance in CSS Level 1.


HTML inspector

  • The <font> element is obsolete and should not be used.
<font size="4">For more information about Smith College, you can visit its website <a href="http://www.smith.edu" target="_blank">here</a></font>.

MDN documentation:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/font

Obsolete
This feature is obsolete. Although it may still work in some browsers, its use is discouraged since it could be removed at any time. Try to avoid using it.

Cheers and happy coding :slight_smile:


#3

Apologies @erretres I only saw your response now, must go set my notifications better! Thanks so much for taking the time to have a look at my project, that is super helpful! Going to go back and fix it up today.

Thanks again! :slight_smile:


#4

You’re welcome :smile:.

Cheers and happy coding :slight_smile: