Feedback on fcc survey form project

Hi @StudiousArgyle !

I changed the title of your post to remove the codepen link.
You will get more replies to your posts if you have a more descriptive title.

Just a few thoughts from me. :grinning:

I think the color contrast between the survey background and white text makes it hard to read sometimes.
Maybe you could make the survey form background a little bit darker.

Also, I would suggest formatting your css

For the value attributes in the option elements, they should match the text values.

For example, this

      <option value="10">10</option>
      <option value="10">9</option>
      <option value="10">8</option>

really should be this instead

      <option value="10">10</option>
      <option value="9">9</option>
      <option value="8">8</option>

Remember that the data provided for the value attribute is what is going to be submitted to the server if this were a functioning form.

For the inputs, you might consider using a class.

Instead of this:

input[type="text"],
input[type="number"],
input[type="email"] {
  display: flex;
  flex-direction: center;
  margin: auto;
  width: 200px;
  border-radius: 83px;
}

you could use a class like this

.user-input{
  display: flex;
  flex-direction: center;
  margin: auto;
  width: 200px;
  border-radius: 83px;
}

Hope that helps!

1 Like

Yes, it helps a lot. I meant to change the option values, but it slipped my mind.
I couldn’t think of a uniquely descriptive title.

How is it now? I fixed the option values and changed the form words to DarkSlateGray

1 Like