Feedback on First Challenge!

Feedback on First Challenge!
0.0 0

#1

Hello lovely community!

I should be grateful to anyone who would spare a moment to review my first challenge - the tribute website. I did have to search quite a few different forums and areas to achieve the functionality I wanted, and it’s still not perfect, but I do hope it’s a good start! I imagine the code is quite messy, so am eager and happy to learn how to improve.

Many thanks!
Y.


#2

This is awesome! I really like the div that follows you down the page as you scroll. Very clean, minimalist design. Good stuff :slight_smile:


#3

Thanks for the very kind comment and feedback Sam :slight_smile: I learned A LOT with that scrolling menu, for sure!


#4

Hello there!

When I ran your code and saw the name Audrey Hepburn, I just gotta see! I love her in Roman Holiday, lol :heart: Anyway, just like what Sam said, the scrolling thingy was awesome! As a user though, I would appreciate any label for those clickable pictures. First thing that came to my mind was, “Where would this lead me?” But who knows, maybe it’s just me? :laughing:

Also, I don’t know what happened (I’m not inspecting the code, lol) but on the bottom, the background you used didn’t come through till the end.

And oh, good job! :slight_smile:


#5

Hi aceAng!

Thank you for the formative feedback and you’re totally right about the links! It’s funny because it crossed my mind and then I think I promptly forgot to do that; I’ll definitely amend that. I also noticed that the background colour doesn’t always reach the end of the left container (this is especially true when viewing on a mobile, which I haven’t wrapped my head around yet). I will definitely look in to that as well! Thanks for the support and I’m so pleased someone else in this community loves Audrey too :star_struck:


#6

Hi @yanayev,

HTML inspector:

  • The id ‘container’ appears more than once in the document:

  • line 13:

div id="container">
        <div id="floated-imgs">
          <img src="https://cdn.catawiki.net/assets/marketing/marketing/upload_images-files/29049-f6d29482c3b2cc835e785e37e5f9793511155169-original.jpg" height="180" width="170"></img>
  • line 31:
<div id="container">
        <div id="floated-imgs">
          <div class= "audrey-gigi">


  • The id ‘floated-imgs’ appears more than once in the document:

  • line 13:

div id="container">
        <div id="floated-imgs">
          <img src="https://cdn.catawiki.net/assets/marketing/marketing/upload_images-files/29049-f6d29482c3b2cc835e785e37e5f9793511155169-original.jpg" height="180" width="170"></img>
  • line 31:
<div id="container">
        <div id="floated-imgs">
          <div class= "audrey-gigi">

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id

The id global attribute defines a unique identifier (ID) which must be unique in the whole document.

  • The <div> element cannot be a child of the <ul> element.
  <h2>Early Life</h2>
    <ul>
      <div id="container">

MDN documentation:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul

Permitted content
zero or more <li> elements, eventually mixed with <ol> and <ul> elements.


Cheers and happy coding :slight_smile:


#7

Hi @erretres and @aceAng!

Thank you both for the wonderfully constructive feedback! I’ve been busy fixing, tidying and applying your observations :slight_smile: I’ve also starting using Atom and am hoping to learn how to integrate my projects between Atom and Github (more complicated than I imagined it seems). Anyway, please have a look and I’m hoping I accurately applied your notes!

Many thanks for all of your attention and kind help!


#8

Have nothing else to say besides it’s wonderfully done! Just do note that this is from a user perspective as I’m new to coding :laughing: It really looked and felt great to me though. :smiley:


#9

Hi @yanayev,

  • There are still errors:

    • The id ‘floated-imgs’ appears more than once in the document:

      • line 14 and 32
    • The <div> element cannot be a child of the <ul> element.

      • line 31


I’ve also been configuring my text editor (emacs: to use magit ), git in the command line is a little uncomfortable :thinking:

Cheers and happy coding :slight_smile: