Feedback on my Floyd Patterson Tribute Page

Code Feedback
1

Hello there.

I’m re-doing the projects of Responsive Web Design because the first time I based myself too much on the examples’ code. This time I’m doing everything from scratch without even looking at the example, just the user stories and the documentation I find googling.

Before submitting my Tribute Page, I would like some feedback so I can improve and make it better, because there is always room for that.

Here it is: https://codepen.io/juangcabo/full/LYWEPye

Thank you in advance. I’m happy to be here.

2 Likes
2

Hi @juangcabo !

I think your page looks good.

Just a couple of things.

I would review the lesson on giving links meaningful names.

Wikipedia entry is not that accessible.

I would avoid inline styles like this.

style="text-align:center;"

I would keep html and css separate.

You have a little bit of repetition here.


#image{
  max-width: 90%;
  display: block;
  margin-left: auto;
  margin-right: auto;
}

#end-img{
  max-width: 90%;
  display: block;
  margin-left: auto;
  margin-right: auto;
}

If there are multiple html elements that share the same css styles then you should use a class to cut down on repetition.

<img class="patterson-images" alt="" src="">

.patterson-images {
  max-width: 90%;
  display: block;
  margin-left: auto;
  margin-right: auto;
}

Hope that helps!

1 Like
3

Thanks for the feedback!
I fixed all the things you mentioned. I also made the font more readable.
I think it looks decent now.

4

Your page looks good @juangcabo. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address. Using HTML5 so you don’t want any obsolete elements. The second error is because the the test script should be right before the closing body tag.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
5

Thank you! I didn’t know about the W3C validator, pretty useful! I fixed everything besides the warning and errors I can ignore because of working in codepen.

Cheers!

1 Like
6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.