Feedback on my page

Code Feedback
1

Hi guys,I just finished on my tribute page,I will love some feedback.
https://codepen.io/adaezebaby/pen/WNorweL

2

Well, if you are going for the FCC certification then you will need to include the tests in your page by including the CDN link:

https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js

I’m guessing you aren’t going to pass all of the tests initially so that will give you something to work on :slight_smile:

1 Like
3

Hi Ada I know you are going for a circular crop on your image but your current dimensions are squishing your image which doesn’t look that great.

In your html I’d change your img src dimensions to be width: 450 and height : 350
These are the regular dimensions of your image and we want to maintain that

In CSS your img coding should be :
img {
border-radius: 50%;
border: 4px solid grey;
object-fit:cover;
width: 300px;
height: 300px;
}

object-fit: cover; fits your image to the full size of the div and the following width and height control the crop of it. You could set it to any px as long as they are the same.
This combined with the 50% border-radius will give you a circle shape.

Hope this helps!

1 Like
4

Hi there,

You might try wrapping your page content in a containing element. Right now the page’s paragraphs are aligned to the left side, which looks odd on a large desktop screen. With a div or main element you can use CSS to give the containing element a max-width and center it using margin, like so:

<style>
  main {
    max-width: 1000px;
    margin: 0 auto;
  }
</style>

<main>
  <p>My page content... </p>
</main>
5

You page doesn’t look finished @adaezebaby. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 1/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue. (Be sure and read more than just the first line of the failing message.)
  • Codepen provides the boilerplate for you. It only expects the code you’d put within the body element in HTML. (No need to include the body tags). For anything you want to add to the <head> element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • For instance links to fonts go in the box labeled ‘Stuff for <head>’
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s).
    • (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the lesson about giving meaningful text to links. For a more thorough explanation read Web Accessibility in Mind.
    • “here” is not accessible
  • Don’t use internal styling or in-line styling. Keep all your styling external.
6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.