Feedback on my portfolio (work in progress)

Feedback on my portfolio (work in progress)
0

#1

I am working on building outmy portfolio, let me know what you think about what I have so far


#2

Looks good so far!

Whenever I hover on nav links and bars appear, it stretches your background vertically. You can stop that effect.
You can do color or animation hover effects on social links.
Try reducing width of your paragraph, it looks stretched out.

Happy coding :slight_smile:


#3

Looks nice.

  1. Your .button-contain has a z-index which is higher than the .nav-container, so the buttons are on top of the nav when you scroll the page.
Summary
@media (min-width: 795px)
.button-contain {
    margin: 0 auto;
    /* z-index: 10000; */
}

You have set a z-index more places then you need to i think, only the nav and the mobile nav needs a z-index as far as i can tell.

  1. As mentioned the bottom-border hover on the nav links are expanding the height of the nav, you can set a fixed height on the nav to avoid it.
Summary
.nav-container {
  height: 54px;
}
  1. The links back to the front page from the form page are incorrect.
Summary

3a. On the desktop nav your portfolio link is href="#portfolio" which becomes "https://pmarre.github.io/contact.html#portfolio" it should be href="index.html#portfolio"
3b. On the mobile nav your links are pointing to href="marre.html" and href="marre.html#portfolio". It should be index.html not marre.html


#4

Thanks for the feedback!


#5

Thanks for the in-depth feedback! I I appreciate the help!