I used an existing product – one of the best Swiss Army Knives out on the market.
It passes all the tests so plus there.
In your nav the “review” and “register” links don’t work (have any function) and the “Victorinox “
In the nav a user would expect a return to the home page but it dose not.
The links work, it’s just the page is too short. I’ve spaced it a bit to it shows more for the review. The subscribe portion is too short though.
Thanks for the feedback.
Your page looks good @Den4. Some things to revisit;
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in HTML. (No need to include the
bodytags). For anything you want to add to the
<head>element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
- Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- Check that a valid email addr has been entered. Throw an error if not.
- You learned to do this when you created the survey form.
- Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for.
Hi. Thanks for the feedback.
With regards to the email validation, I used the type=“email” in the input element? Should I be doing more than this?
Yes. When you did the survey form if the email input wasn’t filled in an HTML5 validation error was thrown. You should do the same thing here.