Hey! I’d love some feedback on my Landing Page and Tribute Page, let me know how best to improve them 
https://codepen.io/nesskiran/pen/yLVqRrV
https://codepen.io/nesskiran/pen/JjbmqyK
Thanks!
1 Like
hello @ns_kn , nice work on your tribute and landing pages.
You have a tiny error in the CSS of both pages. The codepen analyzer should help in this regard.
You may also want to run the html of your Landing page in the W3C validator, there are some minor errors in there.
All the best!
Thanks so much! I’ll validate now. I need to get into the habit of doing it automatically!
Take care
Your pages lookd good @ns_kn. Some things to revisit;
tribute
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in the HTML editor. (No need to include thebodytags). For anything you want to add to the<head>element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- For instance links to fonts go in the box labeled ‘Stuff for <head>’
- Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
- The one for CSS is good. Use it and address the issue(s).
- (The one for HTML misses things which is why I recommend W3C) - Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for. - Reference MDN Docs
- Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
- “click here” is not accessible
landing page
- Same as above re: codepen provides boilerplate and where to put the link to the font
- Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for.- Reference MDN Docs
- Check that the user has entered a valid email addr. Throw an HTML5 validation error if not.
- You learned to do this when coding the survey form
Thank you so much! This has been really helpful, I appreciate it
1 Like