Feedback Request - Portfolio Page

[david.bentley95]

Hi all,

Finally completed the final certification project for the responsive web design path.

Please see a link to the page here.

Link to source code can be found in the github repo here.

Please have a look and provide me with any feedback you have!

Thank you!

[Ray13]

Hi, David! Great job, looks awesome for a beginner! At brief look I found two points would be great to improve:

This video caption needs some margin on the left

And Facebook button’s shape looks stretched up

Overall, good work!

[david.bentley95]

Thank you for your feedback! I definitely agree with both points. I was having a hard time formatting the icons from font-awesome. I re-approached the social media icons in my final portfolio page project and I think it improved greatly:

I also appreciate the comment regarding margin - certainly noticing these design opportunities is a skill I continue to work on

[Joseph1205]

It’s a cool site. Lovely choice of colors.

One thing though:
I see that you’ve applied transitions to some of your elements and I’m not sure if this was intentional but, they only transition in one direction?

It would look better if they transitioned on both directions, like your nav links.

I see in your CSS that you’ve added the transition tag to your :hover instead of the root element

.box {
  height: 20px;
  width: 20px;
}
.box:hover {
  height: 40px;
  transition: 0.5s ease;
}

If your intent was to transition on both directions like on your nav-links (on hover and out), you should add the transition to your .box selector and not the .box:hover selector.

Adding transition to your hover psuedo element makes it so that it only transitions when the mouse is over the target, but It’ll just skip back to it’s original state instead of smoothly animating back. (which doesn’t really look nice)