Feedback requested on tribute project

Code Feedback
1

Hi all,

Please find below link to my project

https://codepen.io/venkateshnandyala/full/oNBMVyB

Please provide your valuable feedback

2

Welcome to the forums @nvenkatesh. Your page looks good. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the chevron in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it and address the issue(s). (Don’t duplicate selectors)
    • (The one for HTML misses things which is why I recommend W3C)
  • Accessibility is about being accessible to all users. Review the giving meaningful text to links lesson. For a more thorough explanation read Web Accessibility in Mind.
    • “wikipedia entry” is not accessible
  • Make your page responsive. Remember, the R in RWD stands for Responsive
    • There’s a horizontal scrollbar on smaller screens. (The #title does not resize and falls out of the container)
  • User’s are not seeing your page the way you want. You may have “DejaVu Sans Mono”, most will not.
3

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.