Feedback Requested - Portfolio project

Code Feedback
1

Good morning!

I just finished my Portfolio Project, will you tell me what you think?

https://codepen.io/dallasviars/pen/WNRYZoe

Thank you!

2

Nice use of buttons at the top

1 Like
3

Hi @dallasviars !

I think your page looks good.

I wouldn’t have empty hrefs like this because you will get an error message when it is clicked.

<a href="">

If you want to keep those two extra placeholder projects, then you could write it like this

    <a href="#">

When clicked, it will scroll to the top instead of displaying an error message.

I don’t think you need to over comment like this.

h1 {
  font-size: 3em;
} /* Adjusts h1 font size */
h2 {
  font-size: 1.75em;
} /* Adjusts h2 font size */
h3 {
  font-size: 1.5em;
} /* Adjusts h3 font size */

When I was first starting out I would do the same thing.
But remember that comments are meant to leave notes for yourself or other developers.

With these first few learning projects, maybe you are leaving notes for yourself as a study tool.

But in general, you don’t need to comment on things that are obvious to other developers like font-size: 1.5em;

Just something to keep in mind as you start to build more advanced projects.

Hope that helps!

4

Thank you for the feedback! I already corrected the empty hrefs and removed some of the comments.

5

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.