Feedback, this time my Personal Portfolio

Code Feedback
1

Hi there

I have now completed the last challenge in the Responsive Web Design course, my Personal Portfolio. If you could kindly have a look and let me know what you think it would be very much appreciated.

It has been quite a learning exercise, hard work at times, occasionally frustrating but very interesting and enjoyable. I have learned a lot, yet I feel I have still only scratched this surface of this topic.

Thanks,
Craig.

2 Likes
2

HI @craig.lunney!

I think your page looks good.

  • You have one small error in your css concerning a media query.

  • On smaller devices the sections don’t line up

alignment?
alignment?964×588 216 KB

  • Sometimes the black text is hard to read against the picture so maybe you can choose another color or create a background around those sections like projects or contact

  • (optional) You could add a css scroll behavior

html {
  scroll-behavior: smooth;
}
3

Nice work

The colors and fonts are little weird
The text boxes could be smaller so more paddding on the outside

Django app the menu button is hiding some words

FCC medical data:
a picture would be nice in the readme because most wont run it
the chart show looks awesome

Overall really good better than me, I need to get to work on some frontend, good job.

4

Hi @jwilkins.oboe

Thanks for taking a look at my page and for your suggestions.

I’ve added some contrasting colour around the black text, and I believe I have fixed the project tile alignment on small screens (it looks okay on mine).

Craig.

1 Like
5

HI @KyleMcClay

Thanks for your comments.

I’ve played around with the text boxes a little, mostly by adding some contrast to the black text.

Regarding the Django technical documentation was the FCC Test menu that was blocking the menu text? It was the only think I could see but I may have missed something.

On the medical data I just copied over the readme file from the FCC challenge, I completely forgot that it made mention of a couple of figures I will need to copy those over as well.

Regards,
Craig.

1 Like