Feedback Tribute Challenge

Code Feedback
1

Hey guys,

Looking for some feed back on this project:

Thanks for your time!
Cheers,

2

Hey @kbventures! Nice tribute page. The requirements for this project aren’t very strict so my review will almost totally subjective.

What I like:

  • The color pallete works really well with the image.
  • Separators between the sections
  • General centered text layout

What I’d change:

  • text align in list items to justify (personal preference)
  • link for the book to image size, not page width. It feels weird.
  • no border for the social buttons container
  • replace social buttons icons with svg icons (ie: popular svg images source https://www.flaticon.com/) and color them to match your theme
  • Emphasize the footer title (ie: change font/make it bigger/add bold/etc. be creative, imagination is the limit) and add some padding/margin to it

It was a pleasure to review your project. Keep up the good work :wink:

1 Like
3

Hello,

Thanks for taking the time to give some feedback. I implemented all changes. For the social icon there’s a color change on hover for the new SVG code.

I am not sure why the image for the “4 Hour Work Week” link to Amazon seems to take more than the image space… any clue how to fix that?

Cheers,

4

Your page looks good @kbventures. Some things to revisit;

  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
1 Like
5

@kbventures I’m getting back to web-dev myself, so my specifics may be a bit rusty, but the problem with the link seems to occur because of the default block display of its parent container. It works well for me if in your styles css page I customize the amazon-link class as following.

.amazon-link{
  display: flex;
  justify-content: center;
  align-items: center;
}

I think because by default it has display: block, both the parent and children tend to stretch as much as possible. This is just an assumption though, more research is needed for a reliable answer.

Merry Christmas and keep coding . :wink:

1 Like