Feedback: Tribute Page -

Code Feedback
1

Hello all, here’s my first post so go easy on me eheh: This is my second tribute page as the first I made was looking identical to the example given.
This time I took the time to do something more elaborate that I could add to my future portfolio, discovering new things while googling for answers maybe adding too much.

all feedback welcome even if it’s just for the aesthetic of the page or the general feel that the page gives you

2

Welcome to the forums @Wuollas. Your page looks good. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>).
    • The test script should be included, with all tests passing, when you submit your projects.
    • Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
  • Run your HTML code through the W3C validator.
    • There are HTML coding errors you should be aware of and address.
    • Since copy/paste from codepen you can ignore the first warning and first two errors.
  • Codepen provides validators for HTML, CSS and JS. Click on the down arrow in the upper right of each section and then click on the respective ‘Analyze’ link.
    • The one for CSS is good. Use it, there’s something to clean up.
      • When you fix one error click analyze again and clean up the next, etc until there are no more errors.
    • (The one for HTML misses things which is why I recommend W3C)
  • The page needs to be responsive. Things fall out of the container on smaller screens.
    • Remember, the R in RWD stands for Responsive
    • It’s easier making a page responsive if widths are in percentages rather than hardcoded with pixels
1 Like
3