Feedback-Tribute page

Code Feedback
1

Hi, everyone!
This is my first attempt to make a tribute. Do have a look and feedbacks are most welcome.
Link: http://codepen.io/sangeethasundar/full/PbbpaV/
Thanks in advance.

2

Hi @SangeethaSundar ,

CSSlinter:

  • Duplicate properties (box-shadow and border-radius)
 #steve{
  margin-top: 20px;
  box-shadow: 10px 10px 5px #888888;
  border-radius: 10px;
  box-shadow: 10px 10px 5px #888888; <-- here
  border-radius: 10px;   <--here
  margin-left: 10px; 
  height: 500px;
  width: 1200px;
}

HTML

  • do not use <br> to increase a gap:
<!--End of Intro-->
    <br>
    <!--End of image and intro-->

MDN documentation:
<br>: The Line Break element - HTML: HyperText Markup Language | MDN

Do not use <br> to increase the gap between lines of text; use the CSS margin property or the <p> element.

Cheers and happy coding :slight_smile:

1 Like
3

Hi @Diego_Perez
I’ll use the margin to increase the space.
And , didn’t notice I’ve written the border-radius and the box-shadow twice. I’ll change it.
Thanks for pointing out. :slight_smile:

1 Like