Hey everyone, I finally completed my tribute page after much struggle. I know it’s far from perfect but I would love some feedback to help me get better and better. Thanks for your time!
Hi @J-Hooligan !
Welcome to the forum!
Congrats on finishing the tribute page!
Struggle is a good thing because it forces us to learn more
Don’t worry about perfection.
Most of your beginner projects will just be for learning purposes.
That is how it was for me.
Here is my feedback:
I would work on giving your link a more accessible name instead of wikipedia page.
You can review this lesson on giving links accessible names.
I really like your use of semantic tags.
That is a plus
I would use codepen’s format tool to avoid stuff like this.
body {
background-color: black;
color: white;
font-family: calibri;
line-height: 1.5;
text-align: center;
margin: 0;
}
We have a little bit of repetition for these properties here
height: auto;
display: block;
margin: auto;
Instead of using ids for the properties, I would use a class.
.img {
height: auto;
display: block;
margin: auto;
}
#img-caption {
width: 400px;
}
#image {
max-width: 100%;
}
Keep up the good work!
Thank you so much for taking the time to look at it and offer your feedback! I greatly appreciate it.
I will definitely check out the lesson on giving links accessible names.
Thank you again!
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.