First project on freeCodeCamp(Tribute page)

Code Feedback
1

Hi,
This is my first ‘proper’ project and would love your feedback and advice. The tribute page is about Akira Toriyama, a very successful manga artist.

Thank you

2

Cool, good job.

If I’m going to be picky…

          <a href="#"><img id="dr_slump" id="img_1" src="https://i.imgur.com/Zg0y8me.jpg" alt="Doctor Slump"></a>

This has two ids. Also, why is the image wrapped in an anchor that doesn’t do anything? For that matter, you are using anchors in a lot of places that don’t do anything:

      <nav>
        <ul>
          <li><a href="#">INTRO</a></li>
          <li><a href="#">TIMELINE</a></li>
          <li><a href="#">LEARN MORE</a></li>
        </ul>
        <hr>
      </nav>

Here are some anchors that are supposed to do something. Those hrefs should be targeting those parts of the page.

      <span id="akiraInfo_flex">
        <!-- <img id="imgToriyama" src="imgs/Akira-Toriyama-1.jpg" alt="Akira-Toriyama"> -->
        <img id="imgToriyama" src="https://i.imgur.com/xTYpjTQ.jpg" alt="Akira-Toriyama">
        <p id="tribute-info">Akira Toriyama (鳥山 明, Toriyama Akira, born April 5, 1955) is a Japanese manga
 /* ... */

A “p” is not supposed to be a child of a “span”. The “span” should probably be a "div:.

I think if you clear those up and fix the failing test, you’re looking pretty good.

3

Hi, thank you for your feedback, the double ID was a mistake, i fixed it.
The images are going to lead to their respective wiki pages, i will add those functionalities later but I’m trying to pass the final test but it’s asking be to set my images to display:block and set the height and width to auto, but this doesn’t allow me to set their sizes and screws up the top row of images, also now there is no space in between.

Do you have any ideas on how I can fix this, thanks.

4

Hi I managed to sort it out, I just changed the actual size of each images externally, and I believe I fixed all the other problems you talked about. If there is anything else wrong with it feel free to share.

5

No, that was what I saw.

Don’t get caught up in “perfection”. Do the job, do your best, but at some point you have to move on. These projects are just learning tools. Learn what you need to, do a good job with the skills you have at this point in time, and move on.