First Tribute Website: Mike Hall (cyclist)

Code Feedback
1

Hey you all,

I wanted feedback for this tribute website.
I wanted to do so much more, have more CSS and a great CSS grid in the page. But I kept it more basic than I really wanted.

But I just wanted to ask for some feedback from you, some hints and tips!

1 Like
2

I’m a big fan of parallax scrolling. Always feels good to me.

I noticed that you’ve misspelled <blockquote> as <blokquote>.
Also, in the footer, I would add some spacing between the Check it and Wikipedia.

This page has been made possible thanks to Wikipedia!Check it!

Other than that it feels pretty natural to me! Great work.

3

I like how you broke down the text into smaller, manageable chunks/rows. Maybe have a look at smaller screen widths. You can simulate mobile devices and larger screens via the dev tools of your browser. On large screens, you might want to wrap the whole text in a container, so it doesn’t become overly wide. Readability on nytimes.com and medium.com articles is pretty good…

1 Like
4

Thx for the feedback!
Going to take that advice and you are right!
I tried to use Flexbox and had a idea about how I wanted to look but it didn’t work. So in a future version I will adjust that.

5

Hi @Hankar-rgb, your page looks good. Some things to revisit;

  • On using codepen. codepen only expects the code you’d put within the <body> </body> tags in HTML. (No need to include the body tags). For anything you want to add to <head> click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.
    • The link to your fonts would go in the box labeled ‘Stuff for <head>’
  • No one is seeing the fonts you specify because they are being called incorrectly. They need to be in quotes. For instance; font-family: "Open Sans"; Same with “Libre Baskerville”.
    • You’ll notice when you put them in quotes that the results list is still not bold. That’s because you failed to also link to the bold font. You did it correctly with ‘Libre Baskerville’ but not with ‘Open Sans’.
  • Once you have that correct, since the dates in the list are bold you could maybe do away with the bullet points.
  • you missed closing your <ul>
  • You should make your link away accessible. Review the lesson about giving meaningful text to links.
2 Likes
6

Thanks for the feedback!
A few mistakes, but that is the reason why I posted it.
Going to fix that :slight_smile:

1 Like
7