Foreign Currency Exchange - Redesigned! - Feedback Pleeeeease

Hi! What can I do to improve this application?
Try it on the phone/tablet/desktop if you can.
Looking for all kinds of criticism, you can be harsh or not harsh.
I made the logo, background image, and favicon myself using Gimp.

Here is the application.

Foreign Currency Exchange

Here is the code.


Hi Brandon. The design of it is nice, but it does not convert the money correctly and it shows the converted currency always in dollars even when I was converting to euros or any other currency.

The page displays correctly on the desktop and on the phone as well.

1 Like


1 Like

Thank you very much for the feedback! You have made some good points. I was not thinking about the dollar symbol. I will make some changes. Now how about the money not being converted correctly? Are the numbers off? I think that Python might be rounding the number a bit. I am making a query from an exchange website API that should have accurate conversion rates.

@Genome22 Fixed project! Thanks to you. Now it is working better. I also updated the code so that if a person selects currencies from the same country it will return an equal amount.

1 Like

Hi @brandon_wallace, well done to the changes that you have made in your project, good job. :slight_smile:

1 Like

Looks very cool. It is a little hard to find the right currency, so I think it might be a good idea to sort the list of currencies, probably alphabetically, but maybe want the common ones (USD, EUR, GBP, etc.) at the top, above an <hr /> tag.

Regarding the styling, I would probably add a bit of padding-left and padding-top as it is quite close to the top-left edge of the screen on Desktop. On Mobile, it looks good, but I think I would look better if it was centred.

If you wanted to go further you could add a slide rule, and keyboard up and down buttons to choose the value and also add a button to switch the values (i.e. if you are converting USD to AUD, with one click you can change to convert AUD to USD).

Nice Work!!

1 Like

Hey Brandon,
I see that you have the conversion for USD to pretty much all other currencies worked out. What you might want to do when it isn’t USD to other currencies is make the USD conversion behind the scene and then make the conversion to the other currency.

USD to PLN = PLN (this works just fine.)

PLN to USD = USD (this also works.)

MXN to PLN = ??? (doesn’t work.)

MXN to PLN = MXN to USD to PLN

I hope that makes sense.

1 Like

@sgedye THANKS!!! I have improved the project thanks to your recommendations. I added padding in desktop mode, it was too close to the edge of the screen before. I thought the dollar bill in the background balanced out the design. Thinking about the keyboard effect, do you know of any way I can implement something like that? Have you seen other websites like that?

@ADean THANKS!!! I had some problems with the elementry level math. LOL. I fixed the calculation and compared it with other websites. The calculation matches up most of the time except for the cents.

I have redesign this project after thinking about it for a while.
The calculation appears to be working 100% now.
Can anyone find any thing I could improve on it?
What do you guys think?

I have one pretty strong UX beef right away: your placeholder suggests me to type “$10” and it throws an error when I do. Why on Earth would you do that? :slight_smile:

1 Like

Lol, that is an example of what a person could type since the input field does not have a label. How do you think I should do it in your opinion?

You can use $ as a permanent prefix like this:

1 Like

@snigo Thank you. I learn something new everyday. That is a good idea. I will make some changes to my project.

Looks good @brandon_wallace but I have a question. Is it always U.S. dollars to any other currency?

  • If so, then add the dollar prefix to the input area but then you should take away the FROM dropdown
  • If it’s not always starting with US currency and I can start from any countries and convert to another countries currency then there shouldn’t be a dollar prefix.

Since you don’t display a currency symbol on the output I don’t think you need one on the input.

1 Like

For the output, you could use Intl Object

So it will show correct format in each currency.

1 Like

@Roma Thank you my brother. Very useful information. It is always good to get another set of eyes on a project to get another perspective. I see your point, I will make changes to improve my project. The starting amount can be any currency. I used USD because the data from the API uses USD as the base currency. From there, it gets converted to other currencies.

@padunk Nice one! I have not heard of that. I did consider adding Flask-Babel to the project.

Thanks so much for taking the time to comment on my project!

1 Like

I’d make the drop down arrows easier to click by making them like 3x the width… I am just thinking about someone on a mobile trying hit the arrow without hitting either side. Unless than can click anywhere on the field then I guess it doesn’t matter (although I think it’d look better wider anyway).

1 Like

@sgedye I am in total agreement brother. Thank you again for providing an excellent suggestion. I will make the change, I just need to figure out how to implement a wider down arrow.