Hi guys!
I just finished my tribute page and want your feedback to help me improve.
Thank you!
html {
scroll-behavior: smooth;
}
That’s a really nice looking page. Do you have design experience?
The test suite isn’t included. When you submit your page, It should include the test suite with all tests passing.
Great job!
Your page looks good @krssdina. Some things to revisit;
- Keep the test script when forking the pen (
<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)- The test script should be included, with all tests passing, when you submit your projects.
- Codepen provides the boilerplate for you. It only expects the code you’d put within the
bodyelement in HTML. (No need to include thebodytags). For anything you want to add to the<head>element click on the ‘Settings’ button, then HTML and add it into the ‘Stuff for <head>’ box.- For instance links to fonts go in the box labeled ‘Stuff for <head>’
- Run your HTML code through the W3C validator.
- There are HTML coding errors you should be aware of and address.
- Do not use the
<br>element to force line breaks or spacing. That’s what CSS is for. -
overflow-x: hidden;will completely hide anything that extends outside its container element horizontally. It’s recommended to not do this, and refactor your CSS to be more responsive - otherwise it is possible for your site to appear to be missing content.
(screenshot attached) - Keyboard only users have a hard time seeing choices in the navbar
Wow, this is so much better than I put together when I did it.
Not sure how you feel about it, but how about making a link on each photo to the IMDB page for that movie?
Of course you have to weigh up the pros and cons of how to do it, in a new tab so they stay on your page? think about the secure ways to do that so they don’t get tab nabbed, etc.,
Nice work though, given me some ideas now 
This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.