Hey! Just recently finished my tribute page and hoping to get some feedback

Code Feedback
1

Coderpen: https://codepen.io/coderbro6/pen/xxLgPRN
Website: https://codepen.io/coderbro6/full/xxLgPRN

2

Hello coderbro!

I liked your color schema in contrast to background using same color. Your page looks good for mobile viewing, but not comfortable for viewing on larger screens such as desktop.

3

Your font size becomes too large on wide screens. You use vw for font size, which i wont recommend, unless you are making a billboard :wink:

4

Your page looks good @coderbro. Some things to revisit;

  • Keep the test script when forking the pen (<script src="https://cdn.freecodecamp.org/testable-projects-fcc/v1/bundle.js"></script>)
    • The test script, with all tests passing, should be included when you submit your projects.
    • Your page passes 8/10 user stories. Click the red button to see which test(s) are failing and text to help you correct the issue.
      Be sure and read more than just the first line of the failing message. The ability to read and comprehend error messages is a skill you’ll need to acquire as a developer. Ask questions on what you don’t understand.
  • Run your HTML code through the W3C validator.
    • There are HTML syntax/coding errors you should be aware of and address.
      Since copy/paste from codepen you can ignore the first warning and first two errors.

As a suggestion (you don’t have to implement if you don’t want) why not have the “tom brady’s awards” either as a nested list or as a separate list. The way it is now everything runs together and presents a bad UX as it is hard for the user to read.

5

thanks! I’m a little stuck on how to make the picture smaller. could you help me with that please?

6

This topic was automatically closed 182 days after the last reply. New replies are no longer allowed.