Hi , here is my first project - Tribute Page. Please do review

link: https://codepen.io/junaidshaikh_js/pen/eYzbGOw
Thank you.

Hi @junaidshaikh_js. Congratulations upon completing this project and making all tests pass.
I would suggest reducing the width of the text to make it easier to read. It is taking almost the entire width of the viewport.

1 Like

why putting line-height: 0px; ?
when the text wrap, the lines will go on top of each other.

1 Like

Your page looks good @junaidshaikh_js. Some thing to revisit;

  • User’s are not seeing your page the way you want them to. Most won’t have ‘Baloo Bhai 2’ loaded on their computer and you neither link to it (head element in HTML) or import it (CSS).
1 Like

Thank you @nibble , i will do that.

Yes @bedward I just checked it and it is getting on top of each other when wrapping. I also changed it, the reason the did it was to eliminate the distance between the title and subtitle.

I forgot to link the font, I corrected it. Thank you for checking out @Roma

1 Like

if you want to adjust the distance you can use margins instead of line-height, good luck!

1 Like